You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ericm-db (via GitHub)" <gi...@apache.org> on 2026/02/06 20:51:25 UTC
[PR] [SPARK-55402][SS] Move streamingSourceIdentifyingName from CatalogTable to DataSource [spark]
ericm-db opened a new pull request, #54185:
URL: https://github.com/apache/spark/pull/54185
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR refactors the streamingSourceIdentifyingName field to move it from CatalogTable into DataSource as a constructor parameter. The changes include:
1. DataSource.scala: Added streamingSourceIdentifyingName as an optional constructor parameter
2. StreamingRelation.scala: Updated StreamingRelation.apply() to read the name from DataSource instead of CatalogTable
3. DataSourceStrategy.scala: Modified FindDataSourceTable.getStreamingRelation() to pass the name directly to DataSource constructor instead of copying it onto CatalogTable
4. CatalogTable (interface.scala): Removed the streamingSourceIdentifyingName field entirely
5. Test updates: Updated test files to reflect the new architecture
### Why are the changes needed?
streamingSourceIdentifyingName represents query-specific metadata (which source name was assigned in a particular streaming query plan), not an intrinsic property of the table itself. Storing it in CatalogTable breaks table equality semantics:
- Two references to the same table in a single query can have different streamingSourceIdentifyingName values
- This causes them to compare as unequal via CatalogTable.equals()
- This can impact multi-statement transactions and any caching/deduplication logic that relies on CatalogTable equality
By moving this field to DataSource (which is already query-specific), we restore proper catalog table equality while maintaining the ability to track streaming source identifying names for stable checkpoints.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit tests
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Claude Opus 4.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55402][SS] Move streamingSourceIdentifyingName from CatalogTable to DataSource [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #54185:
URL: https://github.com/apache/spark/pull/54185#discussion_r2776451643
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala:
##########
@@ -101,7 +102,9 @@ case class DataSource(
partitionColumns: Seq[String] = Seq.empty,
bucketSpec: Option[BucketSpec] = None,
options: Map[String, String] = Map.empty,
- catalogTable: Option[CatalogTable] = None) extends SessionStateHelper with Logging {
+ catalogTable: Option[CatalogTable] = None,
+ streamingSourceIdentifyingName: Option[StreamingSourceIdentifyingName] = None)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55402][SS] Move streamingSourceIdentifyingName from CatalogTable to DataSource [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54185:
URL: https://github.com/apache/spark/pull/54185#issuecomment-3862512969
## JIRA Issue Information
=== Task SPARK-55402 ===
Summary: Move streamingSourceIdentifyingName from CatalogTable to DataSource
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55402][SS] Move streamingSourceIdentifyingName from CatalogTable to DataSource [spark]
Posted by "brkyvz (via GitHub)" <gi...@apache.org>.
brkyvz commented on code in PR #54185:
URL: https://github.com/apache/spark/pull/54185#discussion_r2776443001
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala:
##########
@@ -101,7 +102,9 @@ case class DataSource(
partitionColumns: Seq[String] = Seq.empty,
bucketSpec: Option[BucketSpec] = None,
options: Map[String, String] = Map.empty,
- catalogTable: Option[CatalogTable] = None) extends SessionStateHelper with Logging {
+ catalogTable: Option[CatalogTable] = None,
+ streamingSourceIdentifyingName: Option[StreamingSourceIdentifyingName] = None)
Review Comment:
Perhaps name this as `userSpecifiedStreamingSourceIdentifyingName`? Wow, that's a mouthful... Maybe `userSpecifiedStreamingSourceName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org