You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Jiri Daněk (Jira)" <ji...@apache.org> on 2019/11/19 16:49:00 UTC
[jira] [Commented] (PROTON-2125) Annoying deprecation warning from
Minitest in Ruby tests
[ https://issues.apache.org/jira/browse/PROTON-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977621#comment-16977621 ]
Jiri Daněk commented on PROTON-2125:
------------------------------------
The use of older, now deprecated, assertion syntax of minitest is on purpose, due to compatibility with Ruby 2.0.0 from PROTON-1738.
The _, value, expect syntax that the deprecation message is asking for came in minitest 5.6.0, in https://github.com/seattlerb/minitest/commit/9e78cc974f3ef0d9716f1cca2675753cf5f648d0.
RHEL 7 has ruby-2.0.0 and rubygem-minitest-4.3.2. That's too old for the new syntax to be supported. Looks the warning cannot be helped now.
The old syntax is scheduled for removal in minitest 6. When minitest 6 adoption increases, this is going to be a problem. It looks fixable, though.
> Annoying deprecation warning from Minitest in Ruby tests
> --------------------------------------------------------
>
> Key: PROTON-2125
> URL: https://issues.apache.org/jira/browse/PROTON-2125
> Project: Qpid Proton
> Issue Type: Test
> Affects Versions: proton-c-0.29.0
> Reporter: Jiri Daněk
> Priority: Trivial
>
> {noformat}
> 41: 0.00 s = .
> 41: A data object#test_0002_can hold a null = DEPRECATED: global use of must_equal from /home/travis/build/jdanekrh/qpid-proton/ruby/spec/data_spec.rb:38. Use _(obj).must_equal instead. This will fail in Minitest 6.
> 41: 0.00 s = .
> 41: A data object#test_0019_raises an error on a negative uint = DEPRECATED: global use of must_raise from /home/travis/build/jdanekrh/qpid-proton/ruby/spec/data_spec.rb:136. Use _(obj).must_raise instead. This will fail in Minitest 6.
> 41: 0.00 s = .
> 41:
> 41: Finished in 0.067732s, 1033.4849 runs/s, 4414.4571 assertions/s.
> 41:
> 41: 70 runs, 299 assertions, 0 failures, 0 errors, 0 skips
> 41/44 Test #41: ruby-data-spec ................... Passed 0.28 sec
> test 42
> Start 42: ruby-exception-handling-spec
> {noformat}
> In e.g. https://travis-ci.org/apache/qpid-proton/jobs/601930436
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org