[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #3559: [KYUUBI #3545] Forbid running the set statement to disable the AUTHZ rules

[GitBox <gi...@apache.org>]

cfmcgrady commented on PR #3559:
URL: https://github.com/apache/incubator-kyuubi/pull/3559#issuecomment-1258898143

   HI, @Yikf thank you for your input.
   
   > There are 3 cases to configure this key for users:
   >
   >  1) spark.sessionState.conf.setConfString(OPTIMIZER_EXCLUDED_RULES.key, somevalues)
   >  2) As a default configuration in spark-default.conf
   >  3) Set command
   
   I think you miss another case to specify this config
   
   4) [Via JDBC Connection URL](https://kyuubi.apache.org/docs/r1.6.0-incubating/deployment/settings.html#via-jdbc-connection-url)
   
   The Kyuubi end users can modify configuration values through methods 1, 3, and 4. This PR only deals with method 3 and I also think it is difficult to restrict users from method 1 (in the scala execution mode)
   
   > logging a WARN only instead of an outright failure.
   
   I don't think logging a WARN message is safe in a production environment
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org