You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Romain Francois <ro...@purrple.cat> on 2018/11/28 15:02:06 UTC
Review [R] pull requests
Hello,
I just sent a big (although mostly benign) pull request to the R package. https://github.com/apache/arrow/pull/3043 <https://github.com/apache/arrow/pull/3043> apparently it involves 115 files, that is a bit scary but some of these files are generated automatically.
There are also other R-related pull requests that would benefit from some review time: I've tagged them with the lang-R label: https://github.com/apache/arrow/pulls?q=is%3Apr+is%3Aopen+label%3Alang-R <https://github.com/apache/arrow/pulls?q=is:pr+is:open+label:lang-R>
Now that I've been given commit rights, it would be good if these issues and pull requests generated more conversation.
Romain
Re: Review [R] pull requests
Posted by Wes McKinney <we...@gmail.com>.
Hi Romain,
I can spend some time reviewing today. Could you give me a rough idea of
the order in which these should be reviewed / merged (if relevant)?
Code review from actual R developers would be helpful, I'll mostly be
reviewing from the Arrow perspective.
Wes
On Wed, Nov 28, 2018, 9:02 AM Romain Francois <romain@purrple.cat wrote:
> Hello,
>
> I just sent a big (although mostly benign) pull request to the R package.
> https://github.com/apache/arrow/pull/3043 <
> https://github.com/apache/arrow/pull/3043> apparently it involves 115
> files, that is a bit scary but some of these files are generated
> automatically.
>
> There are also other R-related pull requests that would benefit from some
> review time: I've tagged them with the lang-R label:
> https://github.com/apache/arrow/pulls?q=is%3Apr+is%3Aopen+label%3Alang-R <
> https://github.com/apache/arrow/pulls?q=is:pr+is:open+label:lang-R>
>
> Now that I've been given commit rights, it would be good if these issues
> and pull requests generated more conversation.
>
> Romain