[GitHub] [dubbo] BurningCN commented on a change in pull request #9831: fix: https://github.com/apache/dubbo/issues/9829

[GitBox <gi...@apache.org>]

BurningCN commented on a change in pull request #9831:
URL: https://github.com/apache/dubbo/pull/9831#discussion_r832958560



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/SimpleReferenceCache.java
##########
@@ -67,7 +67,7 @@
 
     private final Map<String, List<ReferenceConfigBase<?>>> referenceKeyMap = new ConcurrentHashMap<>();
     private final Map<Class<?>, List<ReferenceConfigBase<?>>> referenceTypeMap = new ConcurrentHashMap<>();
-    private final Map<ReferenceConfigBase<?>, Object> references = new ConcurrentHashMap<>();
+    private final Map<String, Object> references = new ConcurrentHashMap<>();

Review comment:
       It seems that the `type of key` does not need to be changed, the `equals` and `toString` methods are rewritten in `AbstractConfig`(`ReferenceConfigBase` is sub class of `AbstractConfig`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org