You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/11/20 23:43:03 UTC
Review Request 15739: Renamed Shared::upgrade() to Shared::own().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15739/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
The 3rd patch of the 3 patches that refactored Owned and supported Owned::share().
Diffs
-----
3rdparty/libprocess/include/process/shared.hpp e0c7991
3rdparty/libprocess/src/tests/shared_tests.cpp 860a9aa
Diff: https://reviews.apache.org/r/15739/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 15739: Renamed Shared::upgrade() to Shared::own().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15739/#review29353
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/shared.hpp
<https://reviews.apache.org/r/15739/#comment56547>
s/is already being/has already been/
- Benjamin Hindman
On Nov. 20, 2013, 10:43 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15739/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 10:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 3rd patch of the 3 patches that refactored Owned and supported Owned::share().
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/shared.hpp e0c7991
> 3rdparty/libprocess/src/tests/shared_tests.cpp 860a9aa
>
> Diff: https://reviews.apache.org/r/15739/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 15739: Renamed Shared::upgrade() to Shared::own().
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15739/
-----------------------------------------------------------
(Updated Nov. 25, 2013, 6:19 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
BenH's comments.
Repository: mesos-git
Description
-------
The 3rd patch of the 3 patches that refactored Owned and supported Owned::share().
Diffs (updated)
-----
3rdparty/libprocess/include/process/shared.hpp e0c7991
3rdparty/libprocess/src/tests/shared_tests.cpp 860a9aa
Diff: https://reviews.apache.org/r/15739/diff/
Testing
-------
make check
Thanks,
Jie Yu