You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2009/04/04 03:06:12 UTC
[jira] Created: (OPENEJB-1014) Make jndi implementation more
pluggable
Make jndi implementation more pluggable
---------------------------------------
Key: OPENEJB-1014
URL: https://issues.apache.org/jira/browse/OPENEJB-1014
Project: OpenEJB
Issue Type: Improvement
Components: container system
Affects Versions: 3.1
Reporter: David Jencks
Assignee: David Jencks
When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
(discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated OPENEJB-1014:
----------------------------------
Attachment: OPENEJB-1014-5.diff
Expect a Context that supports creating missing subcontexts in bind.
Does not include david's proposal for the JndiRequestHandler fix.
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014-2.diff, OPENEJB-1014-3.diff, OPENEJB-1014-4.diff, OPENEJB-1014-5.diff, OPENEJB-1014.diff, XbeanJndiFactory.java
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated OPENEJB-1014:
----------------------------------
Attachment: OPENEJB-1014-4.diff
Applied most of the java: removal bits of the patch: improved PersistenceBuilder patch
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014-2.diff, OPENEJB-1014-3.diff, OPENEJB-1014-4.diff, OPENEJB-1014.diff
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871408#action_12871408 ]
David Jencks commented on OPENEJB-1014:
---------------------------------------
Apply patch 6 in rev 948243. I'm not aware of more problems but want to review again.
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014-2.diff, OPENEJB-1014-3.diff, OPENEJB-1014-4.diff, OPENEJB-1014-5.diff, OPENEJB-1014-6.diff, OPENEJB-1014.diff, XbeanJndiFactory.java
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated OPENEJB-1014:
----------------------------------
Attachment: OPENEJB-1014-3.diff
Add a convenience method to ContainerSystem to simplify getting the root jndi context.
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014-2.diff, OPENEJB-1014-3.diff, OPENEJB-1014.diff
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated OPENEJB-1014:
----------------------------------
Attachment: XbeanJndiFactory.java
Geronmo openejb-xbean gbean. I'm not sure how adaptable to openejb this might be, for geronimo it needs to be a gbean to federate with the global context.
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014-2.diff, OPENEJB-1014-3.diff, OPENEJB-1014-4.diff, OPENEJB-1014.diff, XbeanJndiFactory.java
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated OPENEJB-1014:
----------------------------------
Attachment: OPENEJB-1014-2.diff
More sophisticated patch that...
- introduces a factory to create jndi context and do bind operations.
- removes all the java: prefixes I can find from the global jndi tree access.
- tries to not rely on special case stripping behavior of ivm context, e.g. looking up "openejb/Deployment" to get a context and then looking up "openejb/Deployment/foo" and expecting the same as looking up "foo" in this context.
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014-2.diff, OPENEJB-1014.diff
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated OPENEJB-1014:
----------------------------------
Attachment: OPENEJB-1014.diff
First draft of changes that make openejb work in geronimo using the geronimo global jndi. For discussion, not commit as-is.
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014.diff
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1014) Make jndi implementation more
pluggable
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated OPENEJB-1014:
----------------------------------
Attachment: OPENEJB-1014-6.diff
Geronimo has improved it's java: handling by using the aries jndi code and now the remaining java: prefixes are causing problems. Attached patch removes the ones I've located. I think this does not break the openejb build.
Not applying now in case it conflicts with other ongoing work.
> Make jndi implementation more pluggable
> ---------------------------------------
>
> Key: OPENEJB-1014
> URL: https://issues.apache.org/jira/browse/OPENEJB-1014
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Affects Versions: 3.1
> Reporter: David Jencks
> Assignee: David Jencks
> Attachments: OPENEJB-1014-2.diff, OPENEJB-1014-3.diff, OPENEJB-1014-4.diff, OPENEJB-1014-5.diff, OPENEJB-1014-6.diff, OPENEJB-1014.diff, XbeanJndiFactory.java
>
>
> When run inside other systems such as geronimo there are some reasons to use the geronimo global jndi system. Also relying on the prefix-stripping that the openejb jndi implementation does leads to rather confusing code.
> (discussion on dev list)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.