You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/17 03:18:50 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8139: [PATCH2]mm/backtrace: add backtrace for mempool and memdup for tlsf

xiaoxiang781216 commented on code in PR #8139:
URL: https://github.com/apache/nuttx/pull/8139#discussion_r1071700970


##########
mm/mempool/mempool.c:
##########
@@ -22,13 +22,41 @@
  * Included Files
  ****************************************************************************/
 
+#include <execinfo.h>
 #include <stdbool.h>
+#include <stdio.h>
+#include <syslog.h>
 
 #include <nuttx/kmalloc.h>
 #include <nuttx/mm/mempool.h>
 
 #include "kasan/kasan.h"
 
+#if UINTPTR_MAX <= UINT32_MAX
+#  define MM_PTR_FMT_WIDTH 11
+#elif UINTPTR_MAX <= UINT64_MAX
+#  define MM_PTR_FMT_WIDTH 19
+#endif
+
+#ifndef ALIGN_UP
+#define ALIGN_UP(x, a) (((x) + ((a) - 1)) & (~((a) - 1)))

Review Comment:
   add two space after #



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org