You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 09:06:03 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #11524: [FLINK-16803][hive] Need to make sure partition inherit table spec wh…

JingsongLi commented on a change in pull request #11524: [FLINK-16803][hive] Need to make sure partition inherit table spec wh…
URL: https://github.com/apache/flink/pull/11524#discussion_r401464038
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/TableMetaStoreFactory.java
 ##########
 @@ -68,5 +68,14 @@
 		 * @param partitionPath partition location path.
 		 */
 		void createPartition(LinkedHashMap<String, String> partitionSpec, Path partitionPath) throws Exception;
+
+		/**
+		 * When inserting to an existing partition, the existing partition may need to be updated.
+		 *
+		 * @param partitionSpec the full spec of the target partition
+		 * @param partitionPath partition location path
+		 */
+		default void alterPartition(LinkedHashMap<String, String> partitionSpec, Path partitionPath) throws Exception {
 
 Review comment:
   Can we introduce a `createOrAlterPartition`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services