You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Anna Povzner (Jira)" <ji...@apache.org> on 2020/09/22 02:06:00 UTC

[jira] [Resolved] (KAFKA-10458) Need a way to update quota for TokenBucket registered with Sensor

     [ https://issues.apache.org/jira/browse/KAFKA-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anna Povzner resolved KAFKA-10458.
----------------------------------
    Resolution: Fixed

> Need a way to update quota for TokenBucket registered with Sensor
> -----------------------------------------------------------------
>
>                 Key: KAFKA-10458
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10458
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Anna Povzner
>            Assignee: David Jacot
>            Priority: Major
>             Fix For: 2.7.0
>
>
> For Rate() metric with quota config, we update quota by updating config of KafkaMetric. However, it is not enough for TokenBucket, because it uses quota config on record() to properly calculate the number of tokens. Sensor passes config stored in the corresponding StatAndConfig, which currently never changes. This means that after updating quota via KafkaMetric.config, our current and only method, Sensor will record the value using old quota but then measure the value to check for quota violation using the new quota value. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)