You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Joerg Schaible (JIRA)" <ji...@apache.org> on 2012/06/27 08:38:44 UTC

[jira] [Commented] (SANSELAN-82) Generate tests.jar so client projects can leverage test image data easily

    [ https://issues.apache.org/jira/browse/SANSELAN-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401994#comment-13401994 ] 

Joerg Schaible commented on SANSELAN-82:
----------------------------------------

-1

A test artifact is supposed to contain the test classes and their necessary ressources (i.e. stuff that is loaded with the class loader). To create such an artifact just because you want to access the test *data* (which does definitely *not* belogn to such an artifact) is simply wrong.
                
> Generate tests.jar so client projects can leverage test image data easily
> -------------------------------------------------------------------------
>
>                 Key: SANSELAN-82
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-82
>             Project: Commons Sanselan
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.97
>            Reporter: Farrukh Najmi
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: SANSELAN-82-patch.txt
>
>
> Client projects of commons-imaging need test image data and commons-imaging already has a pretty good set. 
> The simple patch below can be applied to pom.xml to generate commons-imaging-xxx-tests.jar in addition to commons-imaging-xxx.jar to allow client projects to leverage the test data.
> {code}
> Index: pom.xml
> ===================================================================
> --- pom.xml     (revision 1354112)
> +++ pom.xml     (working copy)
> @@ -89,6 +89,14 @@
>        </plugin>
>        <plugin>
>          <artifactId>maven-jar-plugin</artifactId>
> +        <executions>
> +          <execution>
> +            <goals>
> +              <goal>test-jar</goal>
> +            </goals>
> +          </execution>
> +        </executions>
> +        
>          <configuration>
>            <archive>
>              <manifestEntries>
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira