You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/09/09 11:02:57 UTC

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1188: [TINKERPOP-2274] Fixed the issues revealed while compiling and runnin…

spmallette commented on a change in pull request #1188: [TINKERPOP-2274] Fixed the issues revealed while compiling and runnin…
URL: https://github.com/apache/tinkerpop/pull/1188#discussion_r322182327
 
 

 ##########
 File path: gremlin-core/pom.xml
 ##########
 @@ -146,6 +146,23 @@ limitations under the License.
                     </compilerArgs>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>
+                <executions>
+                  <execution>
+                    <id>package-test-lib</id>
+                    <goals>
+                      <goal>test-jar</goal>
 
 Review comment:
   we try to avoid test jars - `TestHelper`is already in `gremlin-test` - https://github.com/apache/tinkerpop/blob/06f5213a22986574751295042aaec3ce232b4cd2/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/TestHelper.java - yes, it is a small code duplication, but I'd prefer that to a special classified artifact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services