You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/10/03 19:00:07 UTC

[jira] [Created] (HADOOP-8875) test-patch.sh doesn't test changes to itself

Eli Collins created HADOOP-8875:
-----------------------------------

             Summary: test-patch.sh doesn't test changes to itself
                 Key: HADOOP-8875
                 URL: https://issues.apache.org/jira/browse/HADOOP-8875
             Project: Hadoop Common
          Issue Type: Bug
          Components: build
            Reporter: Eli Collins


The test-patch.sh script run by the pre commit jobs doesn't handle patches that modify test-patch.sh itself, let's modify it to do so or at least log a warning in the test-patch output to indicate the submitter should test test-patch themselves.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8875) test-patch.sh doesn't test changes to itself

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471807#comment-13471807 ] 

Robert Joseph Evans commented on HADOOP-8875:
---------------------------------------------

I would prefer to see it just output a warning.  It seems very difficult for test-patch to test itself.  
                
> test-patch.sh doesn't test changes to itself
> --------------------------------------------
>
>                 Key: HADOOP-8875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8875
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Eli Collins
>
> The test-patch.sh script run by the pre commit jobs doesn't handle patches that modify test-patch.sh itself, let's modify it to do so or at least log a warning in the test-patch output to indicate the submitter should test test-patch themselves.   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira