You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by je...@apache.org on 2005/08/25 09:28:32 UTC
svn commit: r240012 - in
/xmlgraphics/fop/trunk/src/java/org/apache/fop/render: pdf/PDFRenderer.java
ps/PSRenderer.java
Author: jeremias
Date: Thu Aug 25 00:28:27 2005
New Revision: 240012
URL: http://svn.apache.org/viewcvs?rev=240012&view=rev
Log:
Kerning is currently not supported by the layout engine, so disable it for PDF and add a TODO item for PS.
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java
URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java?rev=240012&r1=240011&r2=240012&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java Thu Aug 25 00:28:27 2005
@@ -1187,7 +1187,9 @@
boolean kerningAvailable = false;
Map kerning = fs.getKerning();
if (kerning != null && !kerning.isEmpty()) {
- kerningAvailable = true;
+ //kerningAvailable = true;
+ //TODO Reenable me when the layout engine supports kerning, too
+ log.warn("Kerning support is disabled until it is supported by the layout engine!");
}
int l = s.length();
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java
URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java?rev=240012&r1=240011&r2=240012&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java Thu Aug 25 00:28:27 2005
@@ -25,6 +25,7 @@
import java.io.OutputStream;
import java.util.Iterator;
import java.util.List;
+import java.util.Map;
// FOP
import org.apache.avalon.framework.configuration.Configuration;
@@ -713,7 +714,16 @@
handleIOTrouble(ioe);
}
}
- //paintText(rx, bl, , f);
+
+ boolean kerningAvailable = false;
+ Map kerning = tf.getKerningInfo();
+ if (kerning != null && !kerning.isEmpty()) {
+ //kerningAvailable = true;
+ //TODO Fix me when kerning is supported by the layout engine
+ log.warn("Kerning info is available, but kerning is not yet implemented for"
+ + " the PS renderer and not currently supported by the layout engine.");
+ }
+
String text = area.getTextArea();
beginTextObject();
writeln("1 0 0 -1 " + gen.formatDouble(rx / 1000f)
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
Re: svn commit: r240012 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render: pdf/PDFRenderer.java ps/PSRenderer.java
Posted by Jeremias Maerki <de...@greenmail.ch>.
No intentions to fix kerning right now. I just documented the problem.
I hope you had good holidays!
On 25.08.2005 11:38:23 Vincent Hennebert wrote:
> Jeremias,
>
> Just in case you intended to do any improvement there: the FOrayFont integration
> may bring some facilities in this area. At least the handling will be different,
> so I don't think it's worth working on this before the integration is done. So
> please leave it as is for now. Thanks!
> I've finished reading the huge amount of mails that have been written to this
> list during August, getting back to work now.
Jeremias Maerki
Re: svn commit: r240012 - in
/xmlgraphics/fop/trunk/src/java/org/apache/fop/render: pdf/PDFRenderer.java
ps/PSRenderer.java
Posted by Vincent Hennebert <vi...@enseeiht.fr>.
Jeremias,
Just in case you intended to do any improvement there: the FOrayFont integration
may bring some facilities in this area. At least the handling will be different,
so I don't think it's worth working on this before the integration is done. So
please leave it as is for now. Thanks!
I've finished reading the huge amount of mails that have been written to this
list during August, getting back to work now.
Regards,
Vincent
jeremias@apache.org a écrit :
> Author: jeremias
> Date: Thu Aug 25 00:28:27 2005
> New Revision: 240012
>
> URL: http://svn.apache.org/viewcvs?rev=240012&view=rev
> Log:
> Kerning is currently not supported by the layout engine, so disable it for PDF and add a TODO item for PS.
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java
> URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java?rev=240012&r1=240011&r2=240012&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFRenderer.java Thu Aug 25 00:28:27 2005
> @@ -1187,7 +1187,9 @@
> boolean kerningAvailable = false;
> Map kerning = fs.getKerning();
> if (kerning != null && !kerning.isEmpty()) {
> - kerningAvailable = true;
> + //kerningAvailable = true;
> + //TODO Reenable me when the layout engine supports kerning, too
> + log.warn("Kerning support is disabled until it is supported by the layout engine!");
> }
>
> int l = s.length();
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java
> URL: http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java?rev=240012&r1=240011&r2=240012&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/PSRenderer.java Thu Aug 25 00:28:27 2005
> @@ -25,6 +25,7 @@
> import java.io.OutputStream;
> import java.util.Iterator;
> import java.util.List;
> +import java.util.Map;
>
> // FOP
> import org.apache.avalon.framework.configuration.Configuration;
> @@ -713,7 +714,16 @@
> handleIOTrouble(ioe);
> }
> }
> - //paintText(rx, bl, , f);
> +
> + boolean kerningAvailable = false;
> + Map kerning = tf.getKerningInfo();
> + if (kerning != null && !kerning.isEmpty()) {
> + //kerningAvailable = true;
> + //TODO Fix me when kerning is supported by the layout engine
> + log.warn("Kerning info is available, but kerning is not yet implemented for"
> + + " the PS renderer and not currently supported by the layout engine.");
> + }
> +
> String text = area.getTextArea();
> beginTextObject();
> writeln("1 0 0 -1 " + gen.formatDouble(rx / 1000f)
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
>