You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hemanth Yamijala (JIRA)" <ji...@apache.org> on 2008/11/27 10:57:47 UTC
[jira] Created: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
saveVersion.sh could write a package-info.java that cannot be compiled when used with git
-----------------------------------------------------------------------------------------
Key: HADOOP-4738
URL: https://issues.apache.org/jira/browse/HADOOP-4738
Project: Hadoop Core
Issue Type: Bug
Components: build
Reporter: Hemanth Yamijala
When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
{{revision=`git log -1 --pretty=oneline`}}
This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4738:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-4738
> URL: https://issues.apache.org/jira/browse/HADOOP-4738
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Hemanth Yamijala
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: 4738-0.patch
>
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651307#action_12651307 ]
Hemanth Yamijala commented on HADOOP-4738:
------------------------------------------
An internal git setup we have has the following in the git log:
{code}
$ git log -1 --pretty=oneline
997675219014cc741fc930930333d1414ae9a514 HADOOP-4704. Fix javadoc typos "the the". (szetszwo)
{code}
And build is failing as follows:
{code}
compile-core-classes:
[javac] Compiling 636 source files to ../hadoop/hadoop/build/classes
[javac] ../hadoop/build/src/org/apache/hadoop/package-info.java:4: ')' expected
[javac] @HadoopVersionAnnotation(version="0.20.0-dev", revision="997675219014cc741fc930930333d1414ae9a514 HADOOP-4704. Fix javadoc typos "the the". (szetszwo)",
[javac] ^
[javac] 1 error
BUILD FAILED
{code}
> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-4738
> URL: https://issues.apache.org/jira/browse/HADOOP-4738
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Hemanth Yamijala
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653527#action_12653527 ]
Owen O'Malley commented on HADOOP-4738:
---------------------------------------
+1
> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-4738
> URL: https://issues.apache.org/jira/browse/HADOOP-4738
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Hemanth Yamijala
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: 4738-0.patch
>
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4738:
----------------------------------
Fix Version/s: 0.20.0
Assignee: Chris Douglas
Status: Patch Available (was: Open)
> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-4738
> URL: https://issues.apache.org/jira/browse/HADOOP-4738
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Hemanth Yamijala
> Assignee: Chris Douglas
> Fix For: 0.20.0
>
> Attachments: 4738-0.patch
>
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654079#action_12654079 ]
Hudson commented on HADOOP-4738:
--------------------------------
Integrated in Hadoop-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/680/])
> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-4738
> URL: https://issues.apache.org/jira/browse/HADOOP-4738
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Hemanth Yamijala
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: 4738-0.patch
>
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4738:
----------------------------------
Priority: Trivial (was: Major)
> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-4738
> URL: https://issues.apache.org/jira/browse/HADOOP-4738
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Hemanth Yamijala
> Assignee: Chris Douglas
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: 4738-0.patch
>
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4738) saveVersion.sh could write a
package-info.java that cannot be compiled when used with git
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4738:
----------------------------------
Attachment: 4738-0.patch
> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-4738
> URL: https://issues.apache.org/jira/browse/HADOOP-4738
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Hemanth Yamijala
> Attachments: 4738-0.patch
>
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.