You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by to...@apache.org on 2018/08/09 21:48:13 UTC
[7/9] impala git commit: IMPALA-7411,
IMPALA-7414. Fix failing tests on local filesystem
IMPALA-7411, IMPALA-7414. Fix failing tests on local filesystem
The new test added by IMPALA-7308 failed on local-filesystem builds
because the warehouse path is not directly at /test-warehouse. This
fix prefixes the path appropriately with $FILESYSTEM_PREFIX
Additionally, the fix for IMPALA-5542 made a similar mistake
constructing a path on the Python side of a test case. Fixed by using
the get_fs_path function.
Change-Id: I6922e24a74576d0d000e8e2645a235868583c1e1
Reviewed-on: http://gerrit.cloudera.org:8080/11164
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/d958b477
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/d958b477
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/d958b477
Branch: refs/heads/master
Commit: d958b4779ca3f6403780bc700e4f88a2c18589d7
Parents: 2868bf5
Author: Todd Lipcon <to...@apache.org>
Authored: Wed Aug 8 10:25:12 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Thu Aug 9 19:18:08 2018 +0000
----------------------------------------------------------------------
.../queries/QueryTest/incompatible_avro_partition.test | 3 ++-
tests/query_test/test_scanners.py | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/d958b477/testdata/workloads/functional-query/queries/QueryTest/incompatible_avro_partition.test
----------------------------------------------------------------------
diff --git a/testdata/workloads/functional-query/queries/QueryTest/incompatible_avro_partition.test b/testdata/workloads/functional-query/queries/QueryTest/incompatible_avro_partition.test
index 9ca0df7..23f7abc 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/incompatible_avro_partition.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/incompatible_avro_partition.test
@@ -47,7 +47,8 @@ int, boolean, tinyint, smallint, int, bigint, float, double, string, char, strin
====
---- QUERY
# Add incompatible data in the avro partition.
-alter table mixed partition (part = 2) set location '/test-warehouse/alltypes_avro/year=2009/month=1';
+alter table mixed partition (part = 2)
+ set location '$FILESYSTEM_PREFIX/test-warehouse/alltypes_avro/year=2009/month=1';
refresh mixed;
====
---- QUERY
http://git-wip-us.apache.org/repos/asf/impala/blob/d958b477/tests/query_test/test_scanners.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_scanners.py b/tests/query_test/test_scanners.py
index afbac0f..2e61d20 100644
--- a/tests/query_test/test_scanners.py
+++ b/tests/query_test/test_scanners.py
@@ -295,7 +295,8 @@ class TestParquet(ImpalaTestSuite):
local_file = os.path.join(os.environ['IMPALA_HOME'],
'testdata/data/%s' % filename)
assert os.path.isfile(local_file)
- hdfs_file = '/test-warehouse/{0}.db/{1}'.format(unique_database, filename)
+ hdfs_file = get_fs_path('/test-warehouse/{0}.db/{1}'.format(
+ unique_database, filename))
check_call(['hdfs', 'dfs', '-copyFromLocal', '-f', local_file, hdfs_file])
qualified_table_name = '%s.%s' % (unique_database, table_name)