You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/27 15:49:37 UTC
[GitHub] [cloudstack] div8cn opened a new issue #5161: UI. rbd volume snapshot cannot be rolledback
div8cn opened a new issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
UI
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.15.0.0
4.15.1.0
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
CloudStack 4.15.0.0
ceph 15.2.11
ubuntu 20.04
##### SUMMARY
<!-- Explain the problem/feature briefly -->
Unable to roll back RBD VOLUME snapshot on UI
Use API to complete rbd volume snapshot rollback
snapshot.backup.to.secondary=false
kvm.snapshot.enabled=true
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-909146209
@nvazquez @rhtyd I was not able to detect any change or recently merged PR that would affect RBD rollback on UI nor on API. Still not sure why my tests differ now than the older tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-910783189
@rhtyd I've tested it on the "main" branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] div8cn commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
div8cn commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870661079
no rollback button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-923732975
Same logic revert button from main and 4.15 branch. I don't think this issue from UI. @GabrielBrascher Can you confirm where this error is coming from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-903371225
Thanks @GabrielBrascher, does it need backporting to the 4.15 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-908964876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-895105048
Thanks for sharing @utchoang as per @GabrielBrascher 's comment looks like we need to check the 'revertable' setting - can you confirm against the legacy UI from 4.15/4.14 and raise a PR.
@GabrielBrascher @div8cn any comments? Are you for example seeing the option in old UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-902256567
@utchoang @div8cn @nvazquez @rhtyd I've done some tests with one of the recent commits in the main and it looks to be working fine to revert RBD/Ceph snapshots with KVM.
The button is displayed in the UI and the CephStrategy is called as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-919853400
@GabrielBrascher can you confirm and close this if it's no longer an issue for main/4.16?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-912344753
I see same logic on main as in 4.15, https://github.com/apache/cloudstack/blob/4.15/ui/src/config/section/storage.js#L306
I'm moving this to 4.16 to be tested and closed. cc @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-911389306
@utchoang @shwstppr can you check if the revert snapshot button is shown with same logic in main as in 4.15 and follows the same logic as old UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870667689
@div8cn thanks for confirming.
@rhtyd I am having the same issue; the UI button for reverting a snapshot is "missing".
The new UI presents the button only if the snapshot response has `revertable` as `true`. However, I am getting `revertable` as `false` in snapshots. This includes also a snapshot taken on NFS, not just Ceph/RBD.
List Snapshots via API.
```
cmk> list snapshots filter=name,state,revertable
+-------------------+----------+------------+
| NAME | STATE | REVERTABLE |
+-------------------+----------+------------+
| primary-nfs-snap2 | BackedUp | false |
| primary-nfs-snap | BackedUp | false |
| test-snap1-rbd | BackedUp | false |
+-------------------+----------+------------+
```
Mysql select on snapshot_store_ref checking that it indeed happens with snapshots taken on `NFS` & `RBD`.
```
> select store_role,install_path,state from snapshot_store_ref order by id desc limit 3;
+------------+---------------------------+-------+
| store_role | install_path | state |
+------------+---------------------------+-------+
| Primary | /mnt/<uuid>/<uuid>/<uuid> | Ready |
| Primary | /mnt/<uuid>/<uuid>/<uuid> | Ready |
| Primary | rbd/<uuid>/<uuid> | Ready |
+------------+---------------------------+-------+
```
The UI then will not present the revertable button.
1. Example of the UI buttons for the tested snapshots:
2. Example with the UI "ignoring" the revertable in the response:
It seems that in the past releases it worked because the legacy UI did not check this; the new UI on the other hand has a validation and does not present the button in case revertable is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-894597041
@GabrielBrascher could you work on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870620796
@div8cn by unable you mean that there is not a "button" on the new UI for this?
Or do you mean a failure on the revert via the UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] div8cn commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
div8cn commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870159119
4.15.1 RC3 also has this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-909117165
cc @davidjumani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-869478847
@div8cn have you tested this on 4.15.1.0 RC2? cc @GabrielBrascher @wido
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] div8cn commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
div8cn commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870159119
4.15.1 RC3 also has this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870667689
@div8cn thanks for confirming.
@rhtyd I am having the same issue; the UI button for reverting a snapshot is "missing".
The new UI presents the button only if the snapshot response has `revertable` as `true`. However, I am getting `revertable` as `false` in snapshots. This includes also a snapshot taken on NFS, not just Ceph/RBD.
List Snapshots via API.
```
cmk> list snapshots filter=name,state,revertable
+-------------------+----------+------------+
| NAME | STATE | REVERTABLE |
+-------------------+----------+------------+
| primary-nfs-snap2 | BackedUp | false |
| primary-nfs-snap | BackedUp | false |
| test-snap1-rbd | BackedUp | false |
+-------------------+----------+------------+
```
Mysql select on snapshot_store_ref checking that it indeed happens with snapshots taken on `NFS` & `RBD`.
```
> select store_role,install_path,state from snapshot_store_ref order by id desc limit 3;
+------------+---------------------------+-------+
| store_role | install_path | state |
+------------+---------------------------+-------+
| Primary | /mnt/<uuid>/<uuid>/<uuid> | Ready |
| Primary | /mnt/<uuid>/<uuid>/<uuid> | Ready |
| Primary | rbd/<uuid>/<uuid> | Ready |
+------------+---------------------------+-------+
```
The UI then will not present the revertable button.
1. Example of the UI buttons for the tested snapshots:
2. Example with the UI "ignoring" the revertable in the response:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-895060151
@utchoang can you check if we show the revert button in UI for snapshots, if there's any check for rbd/ceph/kvm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-909967134
@GabrielBrascher can you just confirm if you tested main or 4.15 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-923722847
@GabrielBrascher @utchoang @svenvogel @nvazquez @sureshanaparti @davidjumani @shwstppr @Pearl1594 @DaanHoogland @weizhouapache - any update on this, who's assigned/working on this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-908964876
Ping @GabrielBrascher @utchoang any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870620796
@div8cn Thanks for reporting this issue.
Just to clarify, by `"Unable to roll back RBD VOLUME snapshot on UI"` you mean that there is not a "button" on the new UI for this?
Or do you mean a failure on the revert via the UI?
API command for rollback is working fine at least, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher edited a comment on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-870667689
@div8cn thanks for confirming.
@rhtyd I am having the same issue; the UI button for reverting a snapshot is "missing".
The new UI presents the button only if the snapshot response has `revertable` as `true`. However, I am getting `revertable` as `false` in snapshots. This includes also a snapshot taken on NFS, not just Ceph/RBD.
List Snapshots via API.
```
cmk> list snapshots filter=name,state,revertable
+-------------------+----------+------------+
| NAME | STATE | REVERTABLE |
+-------------------+----------+------------+
| primary-nfs-snap2 | BackedUp | false |
| primary-nfs-snap | BackedUp | false |
| test-snap1-rbd | BackedUp | false |
+-------------------+----------+------------+
```
Mysql select on snapshot_store_ref checking that it indeed happens with snapshots taken on `NFS` & `RBD`.
```
> select store_role,install_path,state from snapshot_store_ref order by id desc limit 3;
+------------+---------------------------+-------+
| store_role | install_path | state |
+------------+---------------------------+-------+
| Primary | /mnt/<uuid>/<uuid>/<uuid> | Ready |
| Primary | /mnt/<uuid>/<uuid>/<uuid> | Ready |
| Primary | rbd/<uuid>/<uuid> | Ready |
+------------+---------------------------+-------+
```
The UI then will not present the revertable button.
1. Example of the UI buttons for the tested snapshots:
2. Example with the UI "ignoring" the revertable in the response:
It seems that in the past releases it worked because the legacy UI did not check this; the new UI on the other hand has a validation and does not present the button in case revertable is false.
PS: on a different test environment I had all NFS snapshots with `revertable=true`. I will take a deeper look at which impact such outcomes and how to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-895084903
@rhtyd @GabrielBrascher In new UI, revert button is only visible when `state === 'BackedUp' && revertable === true`. So in this case, when will the revert button be displayed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-923963798
Closing this issue as per @GabrielBrascher's comment https://github.com/apache/cloudstack/issues/5161#issuecomment-902256567 after testing on main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
nvazquez closed issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-909018770
@GabrielBrascher can you advise if this is something fixed in main but not 4.15 branch, or is this not valid anymore - can we close this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-895185834
From what I have been debugging it is related to the Snapshot response not placing the snapshots in RBD as revertable.
I will take a deeper look at this but it does not look like a UI issue but instead an API response issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-895655756
@rhtyd Through research in branch 4.14, the new UI revert button display condition is the same. I think the problem here is from the API?
https://github.com/apache/cloudstack/blob/4.14/ui/scripts/storage.js#L3199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-908981951
@rhtyd cc @GabrielBrascher I don't know how to solve this, because in my opinion, compared to the old UI, it still seems to work properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-909146209
@nvazquez @rhtyd I was not able to detect any change or recently merged PR that would affect RBD rollback on UI nor on API. Still not sure why my tests differ now than the older tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-909146209
@nvazquez @rhtyd I was not able to detect any change or recently merged PR that would affect RBD rollback on UI nor on API. Still not sure why my tests differ now than the older tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-909018770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #5161: UI: rbd volume snapshot cannot be rolledback
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #5161:
URL: https://github.com/apache/cloudstack/issues/5161#issuecomment-908981951
@rhtyd cc @GabrielBrascher I don't know how to solve this, because in my opinion, compared to the old UI, it still seems to work properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org