You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/23 18:13:50 UTC
[GitHub] [orc] williamhyun opened a new pull request #759: ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
williamhyun opened a new pull request #759:
URL: https://github.com/apache/orc/pull/759
### What changes were proposed in this pull request?
This PR aims to add Java checkstyle rules OuterTypeFilename, UpperEll, and ArrayTypeStyle.
### Why are the changes needed?
To improve code quality.
### How was this patch tested?
Pass the GHA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #759: ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #759:
URL: https://github.com/apache/orc/pull/759#issuecomment-885820804
Thank you, I will merge this and make a new PR for the next rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #759: ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #759:
URL: https://github.com/apache/orc/pull/759#issuecomment-885815221
cc: @dongjoon-hyun
I'll try to find more useful rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #759: ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #759:
URL: https://github.com/apache/orc/pull/759#issuecomment-885821818
Sure! Go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #759: ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #759:
URL: https://github.com/apache/orc/pull/759#issuecomment-886064276
I cherry-picked this to branch-1.7, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] asfgit closed pull request #759: ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #759:
URL: https://github.com/apache/orc/pull/759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org