[GitHub] [bookkeeper] ravisharda commented on issue #2219: Issue #2212: Fix issues in Bookkeeper Docker image that prevented containers from starting up

[GitBox <gi...@apache.org>]

ravisharda commented on issue #2219: Issue #2212: Fix issues in Bookkeeper Docker image that prevented containers from starting up
URL: https://github.com/apache/bookkeeper/pull/2219#issuecomment-568635214
 
 
   > @ravisharda It looks to me that the patch is in good shape
   > is this patch ready for final review ?
   > I have forced a new run of Travis and other CI tests.
   
   Yes, I think it is ready for review. There is an issue that Pedro had reported in Slack that needs to be looked at, but IMO that shouldn't hold up the review. 
   
   > Travis is failing for:
   > org.apache.httpcomponents-httpclient-4.4.1.jar unaccounted for in LICENSE
   > org.apache.httpcomponents-httpcore-4.4.1.jar unaccounted for in LICENSE
   > org.apache.thrift-libthrift-0.9.3.jar unaccounted for in LICENSE
   > 
   > this is weird, because this patch is not changing the list of jars that we are bundling with the binary distribution
   
   Yes, not sure why this is happening. Could these jars be coming as transitive dependencies via `zk-shell`?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services