You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/06 16:50:57 UTC

[GitHub] [spark] gatorsmile commented on a change in pull request #24523: [SPARK-27631][SQL] Avoid repeating calculate table statistics when AUTO_SIZE_UPDATE_ENABLED is enabled

gatorsmile commented on a change in pull request #24523: [SPARK-27631][SQL] Avoid repeating calculate table statistics when AUTO_SIZE_UPDATE_ENABLED is enabled
URL: https://github.com/apache/spark/pull/24523#discussion_r281266437
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
 ##########
 @@ -1073,7 +1073,7 @@ private[client] class Shim_v2_0 extends Shim_v1_2 {
 private[client] class Shim_v2_1 extends Shim_v2_0 {
 
   // true if there is any following stats task
-  protected lazy val hasFollowingStatsTask = JBoolean.FALSE
+  protected lazy val hasFollowingStatsTask = Boolean.box(SQLConf.get.autoSizeUpdateEnabled)
 
 Review comment:
   Is it possible that we can add a test case in org/apache/spark/sql/hive/client/VersionsSuite.scala?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org