You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/09 20:37:34 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #533: Fix default arrow build
alamb opened a new pull request #533:
URL: https://github.com/apache/arrow-rs/pull/533
# Which issue does this PR close?
Built on https://github.com/apache/arrow-rs/pull/532 so review that one first
Closes https://github.com/apache/arrow-rs/issues/529
# Rationale for this change
Arrow does not build today unless `rand 0.8` is included as another dependency of the project; I introduced this in #488 when I upgraded the rand dependency but disabled the default features (which require sys which mean arrow can't be built on webasm anymore)
Since the only use of the `sys` part of the rand dependency is in benchmarks and testing code, I propose simply not building that part of of the arrow crate if default features are turned off
# What changes are included in this PR?
1. Bring enough of the rand crate in by default to build, and `#ifdef` out their use when arrows default features are disabled
# Are there any user-facing changes?
There is a `test_utils` feature flag now, enabled by default, that gates what parts of arrow are compiled if the default features are turned off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #533: Fix default arrow build
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #533:
URL: https://github.com/apache/arrow-rs/pull/533#issuecomment-877443999
It would be nice to have all this test only code somewhere that wasn't the actual arrow crate at all, but since the test code has a backwards dependency on arrow -- (arrow <--> test_util) -- we would have to break that cycle as well, which is a lot of code churn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #533: Fix default arrow build
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #533:
URL: https://github.com/apache/arrow-rs/pull/533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #533: Fix default arrow build
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #533:
URL: https://github.com/apache/arrow-rs/pull/533#issuecomment-877445680
FYI @ritchie46 and @joshuataylor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] joshuataylor commented on pull request #533: Fix default arrow build
Posted by GitBox <gi...@apache.org>.
joshuataylor commented on pull request #533:
URL: https://github.com/apache/arrow-rs/pull/533#issuecomment-877549080
I have tested this by removing rand from my `Cargo.toml` and then changed arrow to this:
```
arrow = { git = "https://github.com/alamb/arrow-rs", branch = "alamb/fix-arrow-default-build" }
```
And everything works well. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #533: Fix default arrow build
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #533:
URL: https://github.com/apache/arrow-rs/pull/533#issuecomment-877473570
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/533?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#533](https://codecov.io/gh/apache/arrow-rs/pull/533?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abd8cfe) into [master](https://codecov.io/gh/apache/arrow-rs/commit/f1fb2b11bbd6350365de010d3e1d676a27602d3a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1fb2b1) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 167 167
Lines 45984 45984
=======================================
Hits 37984 37984
Misses 8000 8000
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvYml0X3V0aWwucnM=) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/533?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/533?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1fb2b1...abd8cfe](https://codecov.io/gh/apache/arrow-rs/pull/533?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org