Re: [PR] Convert Tagsync into webapp and add metrics [ranger]

["Sanket-Shelar (via GitHub)" <gi...@apache.org>]

Sanket-Shelar commented on code in PR #1107:
URL: https://github.com/apache/ranger/pull/1107#discussion_r3978681241


##########
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java:
##########
@@ -174,6 +177,7 @@ public void run() {
         LOG.debug("==> AtlasRESTTagSource.run()");
 
         while (true) {
+            StopWatch eventStopWatchRest = new StopWatch().start();

Review Comment:
   Removed loop-level StopWatch from run(); updateTotalUploadsTime() now records only the updateSink() duration in synchUp(), and sleep runs in finally outside the timer.



##########
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java:
##########
@@ -183,6 +187,11 @@ public void run() {
                     LOG.debug("==> This server is running passive mode");

Review Comment:
   Passive-mode debug log moved to the else branch when the server is not active.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org