You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/13 08:14:09 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #981: Replace constant macros to constexpr variables and enums in headers

PragmaTwice commented on PR #981:
URL: https://github.com/apache/incubator-kvrocks/pull/981#issuecomment-1277215078

   > Hi. Is it better to use `constexpr` here too? https://github.com/apache/incubator-kvrocks/blob/unstable/src/redis_cmd.cc#L63
   
   Sure. I think at least it should be typed `const char * const`, since the top-level `const` qualifier matters for constants (in linkage and storage durations).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org