[GitHub] [iceberg] flyrain commented on a diff in pull request #5872: push down min/max/count to iceberg

[GitBox <gi...@apache.org>]

flyrain commented on code in PR #5872:
URL: https://github.com/apache/iceberg/pull/5872#discussion_r981828564


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -349,4 +349,7 @@ private TableProperties() {}
 
   public static final String UPSERT_ENABLED = "write.upsert.enabled";
   public static final boolean UPSERT_ENABLED_DEFAULT = false;
+
+  public static final String AGGREGATE_PUSHDOWN_ENABLED = "aggregate.pushdown.enabled";
+  public static final String AGGREGATE_PUSHDOWN_ENABLED_DEFAULT = "false";

Review Comment:
   If we have a nice fallback for any aggregation that cannot rely on the statistic completely, we can set the default to be `true`, or remove the property.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org