You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by davebarnes97 <gi...@git.apache.org> on 2017/08/04 18:40:38 UTC
[GitHub] geode pull request #686: GEODE-3396 Provide pub-tools support for product na...
GitHub user davebarnes97 opened a pull request:
https://github.com/apache/geode/pull/686
GEODE-3396 Provide pub-tools support for product name & version varia…
Adds three variables for use in docs:
- geode_product_name
- geode_product_name_long
- geode_product_version
Plus Ruby helper functions to support their use in nested contexts (e.g. YAML frontmatter "title:" constructs) and usage instructions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davebarnes97/geode feature/GEODE-3396
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/686.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #686
----
commit b5d846c32eaf91af79d2158096975e65bd3aa7b6
Author: Dave Barnes <db...@pivotal.io>
Date: 2017-08-04T17:49:05Z
GEODE-3396 Provide pub-tools support for product name & version variables
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #686: GEODE-3396 Provide pub-tools support for product name & ve...
Posted by davebarnes97 <gi...@git.apache.org>.
Github user davebarnes97 commented on the issue:
https://github.com/apache/geode/pull/686
License added to helpers file, as requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #686: GEODE-3396 Provide pub-tools support for product name & ve...
Posted by joeymcallister <gi...@git.apache.org>.
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/686
I think the helpers file needs a license. Otherwise, this LGTM. +1 with license fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #686: GEODE-3396 Provide pub-tools support for product na...
Posted by davebarnes97 <gi...@git.apache.org>.
Github user davebarnes97 closed the pull request at:
https://github.com/apache/geode/pull/686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---