You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2012/11/07 19:20:13 UTC

[jira] [Created] (HBASE-7114) Increment does not extend Mutation but probably should

Andrew Purtell created HBASE-7114:
-------------------------------------

             Summary: Increment does not extend Mutation but probably should
                 Key: HBASE-7114
                 URL: https://issues.apache.org/jira/browse/HBASE-7114
             Project: HBase
          Issue Type: Bug
          Components: Client
            Reporter: Andrew Purtell
            Priority: Minor


Increment is the only operation in the class of mutators that does not extend Mutation. It mostly duplicates what Mutation provides, but not quite. The signatures for setWriteToWAL and getFamilyMap are slightly different. This can be inconvenient because it requires special case code and therefore could be considered an API design nit. Unfortunately it is not a simple change: The interface is marked stable and the internals of the family map are different from other mutation types. The latter is why I suspect this was not addressed when Mutation was introduced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7114) Increment does not extend Mutation but probably should

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498371#comment-13498371 ] 

Ted Yu commented on HBASE-7114:
-------------------------------

bq. The interface is marked stable
Should we perform a poll on dev@hbase and user@hbase to see if anyone is using Increment.setWriteToWAL and Increment.getFamilyMap ?
For Increment.setWriteToWAL, are they using the Increment returned ?
                
> Increment does not extend Mutation but probably should
> ------------------------------------------------------
>
>                 Key: HBASE-7114
>                 URL: https://issues.apache.org/jira/browse/HBASE-7114
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Andrew Purtell
>            Priority: Minor
>
> Increment is the only operation in the class of mutators that does not extend Mutation. It mostly duplicates what Mutation provides, but not quite. The signatures for setWriteToWAL and getFamilyMap are slightly different. This can be inconvenient because it requires special case code and therefore could be considered an API design nit. Unfortunately it is not a simple change: The interface is marked stable and the internals of the family map are different from other mutation types. The latter is why I suspect this was not addressed when Mutation was introduced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira