You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2012/12/03 21:53:58 UTC

[jira] [Commented] (BOOKKEEPER-483) precommit tests only check toplevel rat file, not the one for submodules.

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509038#comment-13509038 ] 

Flavio Junqueira commented on BOOKKEEPER-483:
---------------------------------------------

The patch is quite simple and it looks good to me. I checked the output of QA and it looks right to me. I just need a quick question: should we see the execution of "copyRatFiles clean" in the console output of the build? I can see the ones of "copyRatFiles patch" but not the one for clean.
                
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-483
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira