You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Ritesh H Shukla (Jira)" <ji...@apache.org> on 2021/12/08 05:42:00 UTC
[jira] [Commented] (RATIS-1463) Fix redundant verbose logging at INFO level
[ https://issues.apache.org/jira/browse/RATIS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454964#comment-17454964 ]
Ritesh H Shukla commented on RATIS-1463:
----------------------------------------
This is often seen in the Ozone logs
2021-12-07 16:43:03,370 [69ea4098-4fbd-4489-8ae0-2cb9555ff2d8@group-84DA73E79B8F-FollowerState] INFO impl.FollowerState (FollowerState.java:run(143)) - 69ea4098-4fbd-4489-8ae0-2cb9555ff2d8@group-84DA73E79B8F-FollowerState was interrupted: {}
java.lang.InterruptedException: sleep interrupted
at java.lang.Thread.sleep(Native Method)
at java.lang.Thread.sleep(Thread.java:340)
at java.util.concurrent.TimeUnit.sleep(TimeUnit.java:386)
at org.apache.ratis.util.TimeDuration.sleep(TimeDuration.java:324)
at org.apache.ratis.util.TimeDuration.sleep(TimeDuration.java:309)
at org.apache.ratis.server.impl.FollowerState.run(FollowerState.java:118)
> Fix redundant verbose logging at INFO level
> -------------------------------------------
>
> Key: RATIS-1463
> URL: https://issues.apache.org/jira/browse/RATIS-1463
> Project: Ratis
> Issue Type: Bug
> Components: common
> Reporter: Ritesh H Shukla
> Priority: Minor
>
> There is redundant logging that is done which should be at TRACE level. Starting a PR.
>
> diff --git a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java
> index 9777a854..f6f5f4c4 100644
> --- a/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java
> +++ b/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java
> @@ -140,7 +140,7 @@ class FollowerState extends Daemon {
> }
> }
> } catch (InterruptedException e) {
> - LOG.info("{} was interrupted: {}", this, e);
> + LOG.info("{} was interrupted: {}", this);
> LOG.trace("TRACE", e);
> Thread.currentThread().interrupt();
> return;
--
This message was sent by Atlassian Jira
(v8.20.1#820001)