You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/15 09:19:38 UTC

[GitHub] [apisix] tzssangglass opened a new pull request #4256: fix #4245

tzssangglass opened a new pull request #4256:
URL: https://github.com/apache/apisix/pull/4256


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   use the environment variable HOMEBREW_PREFIX to determine the location of the brew command installer, to adapt this pr for homebrewhttps://github.com/Homebrew/install/pull/373/files
   <!--- If it fixes an open issue, please link to the issue here. -->
   fix #4245 
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #4256: fix: making APISIX compatible on macOS with ARM chip

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4256:
URL: https://github.com/apache/apisix/pull/4256


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tzssangglass commented on pull request #4256: fix: making APISIX compatible on macOS with ARM chip

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #4256:
URL: https://github.com/apache/apisix/pull/4256#issuecomment-841629352


   I didn't include macOS with ARM in the CI test and I'm not sure if I need to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on pull request #4256: fix: making APISIX compatible on macOS with ARM chip

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #4256:
URL: https://github.com/apache/apisix/pull/4256#issuecomment-841713791






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on pull request #4256: fix: making APISIX compatible on macOS with ARM chip

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #4256:
URL: https://github.com/apache/apisix/pull/4256#issuecomment-841713921


   Hi @juzhiyuan could you check if it works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on pull request #4256: fix: making APISIX compatible on macOS with ARM chip

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #4256:
URL: https://github.com/apache/apisix/pull/4256#issuecomment-841713791


   > I didn't include macOS with ARM in the CI test and I'm not sure if I need to.
   
   I'm working on ARM CI, but it seems right now I could not find places could provide CI on silicon m1 🤣 So I guess no worries needed about that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org