You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Justin Bertram (Jira)" <ji...@apache.org> on 2024/10/14 20:12:00 UTC
[jira] [Updated] (ARTEMIS-4749) SIMILAR_BRANCHES.SWITCH in ../activemq/artemis/utils/ThreadDumpUtil.java
[ https://issues.apache.org/jira/browse/ARTEMIS-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Bertram updated ARTEMIS-4749:
------------------------------------
Description:
The static analyzer has detected SIMILAR_BRANCHES.SWITCH: we have identical branches in switch node in [private static String threadInfoToString] [https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ThreadDumpUtil.java#L106-L113|#L106-L113]
!image-2024-05-01-13-30-38-262.png|width=663,height=411!
It seems better to change code this way:
{code:java}
case WAITING:
case TIMED_WAITING:
sb.append("\t- waiting on " + threadInfo.getLockInfo());
sb.append('\n');
break;
default:{code}
was:
The static analyzer has detected SIMILAR_BRANCHES.SWITCH: we have identical branches in switch node in [private static String threadInfoToString] [https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ThreadDumpUtil.java#L106-L113|#L106-L113]
!image-2024-05-01-13-30-38-262.png|width=663,height=411!
It seems better to change code this way:
{{case WAITING:}}
{{case TIMED_WAITING:}}
{{ sb.append("\t- waiting on " + threadInfo.getLockInfo());}}
{{ sb.append('\n');}}
{{ break;}}
{{ default:}}
Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Author E. Bykhanova (e.bykhanova@fobos-nt.ru).
> SIMILAR_BRANCHES.SWITCH in ../activemq/artemis/utils/ThreadDumpUtil.java
> ------------------------------------------------------------------------
>
> Key: ARTEMIS-4749
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4749
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.25.0
> Reporter: e.bykhanova
> Assignee: Justin Bertram
> Priority: Minor
> Fix For: 2.34.0
>
> Attachments: image-2024-05-01-13-29-32-686.png, image-2024-05-01-13-30-38-262.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The static analyzer has detected SIMILAR_BRANCHES.SWITCH: we have identical branches in switch node in [private static String threadInfoToString] [https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ThreadDumpUtil.java#L106-L113|#L106-L113]
>
> !image-2024-05-01-13-30-38-262.png|width=663,height=411!
> It seems better to change code this way:
> {code:java}
> case WAITING:
> case TIMED_WAITING:
> sb.append("\t- waiting on " + threadInfo.getLockInfo());
> sb.append('\n');
> break;
> default:{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact