You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2008/12/27 20:32:33 UTC
svn commit: r729661 - in /james/server/trunk: management-library/
management-library/src/main/java/org/apache/james/management/impl/ProcessorManagement.java
spoolmanager-function/src/main/java/org/apache/james/transport/StateAwareProcessorList.java
Author: rdonkin
Date: Sat Dec 27 11:32:32 2008
New Revision: 729661
URL: http://svn.apache.org/viewvc?rev=729661&view=rev
Log:
Fix null pointer exception
Modified:
james/server/trunk/management-library/ (props changed)
james/server/trunk/management-library/src/main/java/org/apache/james/management/impl/ProcessorManagement.java
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/StateAwareProcessorList.java
Propchange: james/server/trunk/management-library/
------------------------------------------------------------------------------
--- svn:ignore (original)
+++ svn:ignore Sat Dec 27 11:32:32 2008
@@ -1 +1,2 @@
target
+.*
Modified: james/server/trunk/management-library/src/main/java/org/apache/james/management/impl/ProcessorManagement.java
URL: http://svn.apache.org/viewvc/james/server/trunk/management-library/src/main/java/org/apache/james/management/impl/ProcessorManagement.java?rev=729661&r1=729660&r2=729661&view=diff
==============================================================================
--- james/server/trunk/management-library/src/main/java/org/apache/james/management/impl/ProcessorManagement.java (original)
+++ james/server/trunk/management-library/src/main/java/org/apache/james/management/impl/ProcessorManagement.java Sat Dec 27 11:32:32 2008
@@ -30,6 +30,7 @@
import org.apache.mailet.MailetConfig;
import org.apache.mailet.MatcherConfig;
+import javax.annotation.PostConstruct;
import javax.management.MBeanServer;
import javax.management.MBeanServerFactory;
import javax.management.MalformedObjectNameException;
@@ -48,9 +49,13 @@
public void service(ServiceManager serviceManager) throws ServiceException {
SpoolManager processorManager = (SpoolManager)serviceManager.lookup(SpoolManager.ROLE);
setProcessorManager(processorManager);
- registerMBeans(); // move to appropriate place! to initialize()?
}
+ @PostConstruct
+ public void init() {
+ registerMBeans();
+ }
+
private void registerMBeans() {
ArrayList mBeanServers = MBeanServerFactory.findMBeanServer(null);
if (mBeanServers == null || mBeanServers.size() == 0) return; // no server to publish MBeans
Modified: james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/StateAwareProcessorList.java
URL: http://svn.apache.org/viewvc/james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/StateAwareProcessorList.java?rev=729661&r1=729660&r2=729661&view=diff
==============================================================================
--- james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/StateAwareProcessorList.java (original)
+++ james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/StateAwareProcessorList.java Sat Dec 27 11:32:32 2008
@@ -37,6 +37,7 @@
import java.util.HashMap;
import java.util.Iterator;
+import java.util.Map;
/**
* This class is responsible for creating a set of named processors and
@@ -61,13 +62,17 @@
/**
* The map of processor names to processors
*/
- private HashMap processors;
+ private final Map<String, MailProcessor> processors;
+
+ public StateAwareProcessorList() {
+ super();
+ this.processors = new HashMap<String, MailProcessor>();
+ }
/**
* @see org.apache.avalon.framework.service.Serviceable#service(ServiceManager)
*/
public void service(ServiceManager comp) throws ServiceException {
- // threadManager = (ThreadManager) comp.lookup(ThreadManager.ROLE);
compMgr = comp;
}
@@ -82,8 +87,6 @@
* @see org.apache.avalon.framework.activity.Initializable#initialize()
*/
public void initialize() throws Exception {
- //A processor is a Collection of
- processors = new HashMap();
final Configuration[] processorConfs = conf.getChildren( "processor" );
for ( int i = 0; i < processorConfs.length; i++ )
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org