You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/06/26 23:06:49 UTC
[kudu-CR] KUDU-2480: master-stress-test: increase effective DDL timeout
Hello Adar Dembo, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10833
to review the following change.
Change subject: KUDU-2480: master-stress-test: increase effective DDL timeout
......................................................................
KUDU-2480: master-stress-test: increase effective DDL timeout
TSAN master-stress-test is about 10% flaky with DDL timeouts, this
commit bumps the effective timeout from 10s to 30s. dist-test with
stress threads validates that bumping the DDL timeout eliminates test
flakiness.
Change-Id: I45b604aaf3e51756af564aefbcb1300051076d3e
---
M src/kudu/integration-tests/master-stress-test.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/10833/1
--
To view, visit http://gerrit.cloudera.org:8080/10833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45b604aaf3e51756af564aefbcb1300051076d3e
Gerrit-Change-Number: 10833
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] KUDU-2480: master-stress-test: increase effective DDL timeout
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10833 )
Change subject: KUDU-2480: master-stress-test: increase effective DDL timeout
......................................................................
Patch Set 2:
(1 comment)
Sorry I missed this earlier.
http://gerrit.cloudera.org:8080/#/c/10833/2/src/kudu/integration-tests/master-stress-test.cc
File src/kudu/integration-tests/master-stress-test.cc:
http://gerrit.cloudera.org:8080/#/c/10833/2/src/kudu/integration-tests/master-stress-test.cc@160
PS2, Line 160: // The C++ client currently uses the normal RPC timeout to retry DDL
: // operations to alternate masters, which effectively reduces the admin
: // timeout to the RPC timeout. With HMS integration some DDL operations can
: // exceed the default 10s timeout.
: builder.default_rpc_timeout(MonoDelta::FromSeconds(30));
So shouldn't this be conditioned on the value of GetParam()?
--
To view, visit http://gerrit.cloudera.org:8080/10833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45b604aaf3e51756af564aefbcb1300051076d3e
Gerrit-Change-Number: 10833
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 27 Jun 2018 22:53:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2480: master-stress-test: increase effective DDL timeout
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10833 )
Change subject: KUDU-2480: master-stress-test: increase effective DDL timeout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45b604aaf3e51756af564aefbcb1300051076d3e
Gerrit-Change-Number: 10833
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 26 Jun 2018 23:40:43 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2480: master-stress-test: increase effective DDL timeout
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10833 )
Change subject: KUDU-2480: master-stress-test: increase effective DDL timeout
......................................................................
KUDU-2480: master-stress-test: increase effective DDL timeout
TSAN master-stress-test is about 10% flaky with DDL timeouts, this
commit bumps the effective timeout from 10s to 30s. dist-test with
stress threads validates that bumping the DDL timeout eliminates test
flakiness.
Change-Id: I45b604aaf3e51756af564aefbcb1300051076d3e
Reviewed-on: http://gerrit.cloudera.org:8080/10833
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/master-stress-test.cc
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I45b604aaf3e51756af564aefbcb1300051076d3e
Gerrit-Change-Number: 10833
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins