[GitHub] [systemds] OlgaOvcharenko opened a new pull request #1035: Univar and bivar builtins

[GitBox <gi...@apache.org>]

OlgaOvcharenko opened a new pull request #1035:
URL: https://github.com/apache/systemds/pull/1035


   New univar and bivar builtins. Also fixed federated min and max.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] mboehm7 commented on pull request #1035: Univar and bivar builtins

[GitBox <gi...@apache.org>]

mboehm7 commented on pull request #1035:
URL: https://github.com/apache/systemds/pull/1035#issuecomment-679015917


   LGTM - thanks for the patch @OlgaOvcharenko. I just made a few changes: (1) formatting for java code with tabs, dml scripts with two space indentation, (2) added license headers to univar and bivar federated tests, (3) minor cleanups in FederationUtils, and (4) removed the incomplete and failing bivar builtin function for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] asfgit closed pull request #1035: Univar and bivar builtins

[GitBox <gi...@apache.org>]

asfgit closed pull request #1035:
URL: https://github.com/apache/systemds/pull/1035


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org