You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/28 03:26:35 UTC

[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #4035: Post SparkOperationEvent for ExecuteScala & ExecutePython

cxzl25 commented on code in PR #4035:
URL: https://github.com/apache/kyuubi/pull/4035#discussion_r1058033982


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecutePython.scala:
##########
@@ -167,6 +172,11 @@ class ExecutePython(
       }
     }
   }
+
+  override protected def setState(newState: OperationState): Unit = {

Review Comment:
   It sounds pretty good.
   
   This PR should also fix https://github.com/apache/kyuubi/issues/2886



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org