You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2023/05/16 14:50:30 UTC
[GitHub] [airflow] vincbeck commented on a diff in pull request #31297: Add D400 pydocstyle check - core Airflow only
vincbeck commented on code in PR #31297:
URL: https://github.com/apache/airflow/pull/31297#discussion_r1195289812
##########
airflow/utils/sqlalchemy.py:
##########
@@ -51,15 +51,14 @@ class UtcDateTime(TypeDecorator):
"""
Almost equivalent to :class:`~sqlalchemy.types.TIMESTAMP` with
``timezone=True`` option, but it differs from that by:
-
- Never silently take naive :class:`~datetime.datetime`, instead it
always raise :exc:`ValueError` unless time zone aware value.
- :class:`~datetime.datetime` value's :attr:`~datetime.datetime.tzinfo`
is always converted to UTC.
- Unlike SQLAlchemy's built-in :class:`~sqlalchemy.types.TIMESTAMP`,
it never return naive :class:`~datetime.datetime`, but time zone
aware value, even with SQLite or MySQL.
- - Always returns TIMESTAMP in UTC
+ - Always returns TIMESTAMP in UTC.
Review Comment:
To be honest I dont understand the previous 2 level lists. To me the new format makes more sense but I must miss something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org