You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/10 12:25:48 UTC

[GitHub] [beam] aromanenko-dev edited a comment on pull request #15951: [BEAM-13171] Support for stopReadTime on KafkaIO SDF

aromanenko-dev edited a comment on pull request #15951:
URL: https://github.com/apache/beam/pull/15951#issuecomment-990930207


   Seems that this change introduced `Duration` ambiguity and `Java PreCommit` started to fail with:
   ```
   01:21:19 > Task :sdks:java:io:kafka:compileTestJava
   01:21:19 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@2/src/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFnTest.java:155: error: reference to Duration is ambiguous
   01:21:19     public synchronized ConsumerRecords<byte[], byte[]> poll(Duration timeout) {
   01:21:19                                                              ^
   01:21:19   both class java.time.Duration in java.time and class org.joda.time.Duration in org.joda.time match
   01:21:19 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@2/src/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFnTest.java:52: error: a type with the same simple name is already defined by the single-type-import of Duration
   01:21:19 import org.joda.time.Duration;
   01:21:19 ^
   01:21:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@2/src/sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFnTest.java:300: error: reference to Duration is ambiguous
   01:21:21     Instant stopReadTime = startReadTime.plus(Duration.millis(2000));
   01:21:21                                               ^
   01:21:21   both class java.time.Duration in java.time and class org.joda.time.Duration in org.joda.time match
   ```
   
   Interesting that for some reasons it was not caught by this PR checks...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org