You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/09/08 16:04:12 UTC

[jira] [Created] (CASSANDRA-3158) Digest mismatch retries are not correctly versioned by StorageProxy

Digest mismatch retries are not correctly versioned by StorageProxy
-------------------------------------------------------------------

                 Key: CASSANDRA-3158
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.7.1
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
            Priority: Minor
             Fix For: 0.8.6
         Attachments: 3158.txt



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3158) Digest mismatch retries are not correctly versioned by StorageProxy

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3158:
--------------------------------------

    Attachment: 3158.txt

> Digest mismatch retries are not correctly versioned by StorageProxy
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3158) Improve caching of same-version Messages on digest and repair paths

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100483#comment-13100483 ] 

Hudson commented on CASSANDRA-3158:
-----------------------------------

Integrated in Cassandra-0.8 #321 (See [https://builds.apache.org/job/Cassandra-0.8/321/])
    Improve caching of same-version Messages on digest and repair paths
patch by jbellis; reviewed by slebresne for CASSANDRA-3158

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166774
Files : 
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageProxy.java


> Improve caching of same-version Messages on digest and repair paths
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158-v2.txt, 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3158) Improve caching of same-version Messages on digest and repair paths

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100368#comment-13100368 ] 

Sylvain Lebresne commented on CASSANDRA-3158:
---------------------------------------------

For the initial digest reads, it would be nice to use the CachingMessageProducer for the local digest read too.

> Improve caching of same-version Messages on digest and repair paths
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158-v2.txt, 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3158) Improve caching of same-version Messages on digest and repair paths

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100436#comment-13100436 ] 

Jonathan Ellis commented on CASSANDRA-3158:
-------------------------------------------

Note that on merge to trunk I also added a readCallbacks.clear() statement at the beginning of the short-read do/while loop.

> Improve caching of same-version Messages on digest and repair paths
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158-v2.txt, 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3158) Improve caching of same-version Messages on digest and repair paths

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100378#comment-13100378 ] 

Sylvain Lebresne commented on CASSANDRA-3158:
---------------------------------------------

Oh right, my bad. Anyways, lgtm, +1.

> Improve caching of same-version Messages on digest and repair paths
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158-v2.txt, 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3158) Improve caching of same-version Messages on digest and repair paths

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100374#comment-13100374 ] 

Jonathan Ellis commented on CASSANDRA-3158:
-------------------------------------------

no Messages are created for local reads.

> Improve caching of same-version Messages on digest and repair paths
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158-v2.txt, 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3158) Improve caching of same-version Messages on digest and repair paths

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3158:
--------------------------------------

    Summary: Improve caching of same-version Messages on digest and repair paths  (was: Digest mismatch retries are not correctly versioned by StorageProxy)

> Improve caching of same-version Messages on digest and repair paths
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3158) Improve caching of same-version Messages on digest and repair paths

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-3158:
--------------------------------------

    Attachment: 3158-v2.txt

v2 also lazy-initializes the caching producer for the initial digest reads, and updates comments

> Improve caching of same-version Messages on digest and repair paths
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-3158
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3158
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.6
>
>         Attachments: 3158-v2.txt, 3158.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira