You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/24 11:45:14 UTC
[GitHub] [incubator-dolphinscheduler] nauu opened a new pull request #1557:
Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils
nauu opened a new pull request #1557: Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1557
## What is the purpose of the pull request
For #1465.
1. Add FlinkArgsUtilsTest
2. Optimize FlinkArgsUtils and fix bug, use StringUtils.isNotEmpty(queue) instead of StringUtils.isNotEmpty(others)
3. Add the UT path in pom
## Brief change log
- *Add FlinkArgsUtilsTest.java*
- *Edit FlinkArgsUtils.java*
- *Add UT path to root pom.xml*
## Verify this pull request
This change added tests and can be verified as follows:
- *Added FlinkArgsUtilsTest to verify the change.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1557:
Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils
Posted by GitBox <gi...@apache.org>.
lgcareer merged pull request #1557: Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1557:
Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1557: Add FlinkArgsUtilsTest which is the UT of FlinkArgsUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1557#issuecomment-568733074
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@79ac38a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1557 +/- ##
=====================================
Coverage ? 8.13%
=====================================
Files ? 272
Lines ? 13649
Branches ? 2163
=====================================
Hits ? 1110
Misses ? 12462
Partials ? 77
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100% <ø> (ø)` | |
| [...g/apache/dolphinscheduler/common/model/Server.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1NlcnZlci5qYXZh) | `0% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=footer). Last update [79ac38a...949c468](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1557?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services