You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/03/02 12:13:45 UTC
[GitHub] [celix] Oipo opened a new pull request #326: Feature/zmq v2 fixes
Oipo opened a new pull request #326:
URL: https://github.com/apache/celix/pull/326
Fix use after free and memory leaks in ZMQ v2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on a change in pull request #326: Feature/zmq v2 fixes
Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #326:
URL: https://github.com/apache/celix/pull/326#discussion_r585737908
##########
File path: bundles/pubsub/pubsub_admin_zmq/v2/src/pubsub_zmq_topic_receiver.c
##########
@@ -133,7 +133,7 @@ pubsub_zmq_topic_receiver_t* pubsub_zmqTopicReceiver_create(celix_bundle_context
pubsub_zmq_topic_receiver_t *receiver = calloc(1, sizeof(*receiver));
receiver->ctx = ctx;
receiver->logHelper = logHelper;
- receiver->serializerType = serializerType;
+ receiver->serializerType = strndup(serializerType, 1024*1024);
Review comment:
use celix_utils_strdup which underwater uses strndup
##########
File path: libs/utils/include/hash_map.h
##########
@@ -75,6 +75,8 @@ UTILS_EXPORT void *hashMap_put(hash_map_pt map, void *key, void *value);
UTILS_EXPORT void *hashMap_remove(hash_map_pt map, const void *key);
+UTILS_EXPORT void *hashMap_removeFreeKey(hash_map_pt map, const void *key);
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo merged pull request #326: Feature/zmq v2 fixes
Posted by GitBox <gi...@apache.org>.
Oipo merged pull request #326:
URL: https://github.com/apache/celix/pull/326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on pull request #326: Feature/zmq v2 fixes
Posted by GitBox <gi...@apache.org>.
Oipo commented on pull request #326:
URL: https://github.com/apache/celix/pull/326#issuecomment-789553292
I don't know why the `pubsub_tcp_wire_v2_tests` is failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org