You are viewing a plain text version of this content. The canonical link for it is here.

Posted to devnull@infra.apache.org by "himanshug (GitHub)" <gi...@apache.org> on 2018/08/23 22:41:41 UTC

[GitHub] [incubator-druid] himanshug commented on issue #6223: make COMPLEX column filterable in Druid code

> Would it make sense to add a canFilter method to ColumnCapabilities to have a finer level of control than just mapping filterability directly to ValueType?

Actually I think existence of `Filterable.FILTERABLE_TYPE` is redundant. For me, ColumnCapability.hasBitmapIndexes() is already the indication whether column supports filtering or not. So, one thing to do is to remove `Filterable.FILTERABLE_TYPE` altogether and adjust the code in `ColumnSelectorBitmapIndexSelector` to not use that.

however, I would like to keep things simple for this PR and not cause any unwanted side effects as above suggestion needs to get tested appropriately.


[ Full content available at: https://github.com/apache/incubator-druid/pull/6223 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org