[GitHub] flink pull request #5943: [FLINK-9275][streaming] add taskName to the output...

[NicoK <gi...@git.apache.org>]

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5943

    [FLINK-9275][streaming] add taskName to the output flusher thread's name

    ## What is the purpose of the change
    
    All output flusher threads are named "OutputFlusher" while at the only place the `StreamWriter` is initialized, we already have the task name at hand.
    
    ## Brief change log
    
    - add `taskName` to the output flusher thread's name
    - unify output flusher name with thread name to use the same format the async, timer, Kafka,... helper threads use
    - fix a debug statement missing a format string for one parameter
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage. Also, this was tested in a local cluster with debug statements on.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-9275

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5943
    
----
commit 971a1dd64ea957bc4d42cdf72bc98a3d61dea01c
Author: Nico Kruber <ni...@...>
Date:   2018-04-30T13:02:26Z

    [hotfix] fix a debug statement in StreamTask

commit 0fc95295e5d0804482a9a6eb3467e57921e5964b
Author: Nico Kruber <ni...@...>
Date:   2018-04-30T13:02:43Z

    [FLINK-9275][streaming] add taskName to the output flusher thread's name

----


---

[GitHub] flink issue #5943: [FLINK-9275][streaming] add taskName to the output flushe...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5943
  
    Good fix, thanks, merging...


---

[GitHub] flink pull request #5943: [FLINK-9275][streaming] add taskName to the output...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5943


---