You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/09 03:33:23 UTC
[GitHub] [pulsar] mangoGoForward opened a new pull request, #17557: [feat][ci]: Check PR title with semantic
mangoGoForward opened a new pull request, #17557:
URL: https://github.com/apache/pulsar/pull/17557
Signed-off-by: mango <xu...@foxmail.com>
Master Issue: #15311
### Motivation
Follow the guide of [PIP 198](https://docs.google.com/document/d/1sJlUNAHnYAbvu9UtEgCrn_oVTnVc1M5nHC19x1bFab4/edit#) and [Guide](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit?pli=1#heading=h.wu6ygjne8e35), we support a job to standardize PR naming convention using GitHub Action, but this PR finished only one task(Create “check PR title” job in GitHub check), other task involves modifying [docbot](https://github.com/apache/pulsar-test-infra/tree/master/docbot), so we will commit another PR to solve.
### Modifications
Add a job to check PR title with [semantic GitHub Action](https://github.com/amannn/action-semantic-pull-request)
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
Modify github workflow
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966734383
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
I know that community want not to add a new workflow, there are many workflow need to management, and the other task is add labels based on pr title, so I want to add it as a job in this workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966736259
##########
.github/workflows/semantic.yaml:
##########
@@ -0,0 +1,54 @@
+name: "PR Lint"
Review Comment:
Just mean this workflow is aim to check pr with a rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece closed pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
nodece closed pull request #17557: [feat][ci] Check PR title with semantic
URL: https://github.com/apache/pulsar/pull/17557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966796899
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
But if you insist on this topic, I don't think it's a blocker. Pay as you go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966716587
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
But why? They are for totally different things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966767087
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
Since @lhotari & @nicoloboschi are working on this domain now. I'd like to pull them for inputs on this topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1249971687
Hi @mangoGoForward any blockers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on pull request #17557: [feat][ci]: Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1241461564
And I test it in my repo, please see https://github.com/mangoGoForward/C/pull/3 , more screenshot like blow:
Normal:
Missing scope:
Error scope:
<img width="1424" alt="image" src="https://user-images.githubusercontent.com/35127166/189266722-445c4292-ac4a-43ff-a5ec-7930872fc3b6.png">
Missing type:
Error type:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1250684557
> Hi @mangoGoForward any blockers?
Yes, seems we should write an new action in [pulsar-test-infra](https://github.com/apache/pulsar-test-infra) to customize the error message instead of using [semantic GitHub Action](https://github.com/amannn/action-semantic-pull-request)， like:
```
Please follow [Pulsar Pull Request Naming Convention Guide](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#) to write a PR title.
```
I will test it well and continue to commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] maxsxu commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
maxsxu commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1254429161
@mangoGoForward Thank you! I think it's pretty close.
May need to make the `TitleUnmatchPattern` as an issue comment to achieve the effect mentioned by @Anonymitaet before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966688509
##########
.github/workflows/semantic.yaml:
##########
@@ -0,0 +1,54 @@
+name: "PR Lint"
Review Comment:
What does "Lint" mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] maxsxu commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
maxsxu commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966772608
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,51 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ check-pr-title:
+ if: github.event.action == 'opened' || github.event.action == 'edited'
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
Review Comment:
Do we really need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966791736
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
@maxsxu checking PR title is among the whole project and actually a project basic settings. It's no way to be a docs-related only job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1254405162
> Thanks @mangoGoForward Please feel free to reach out to me if you need any help.
Hi, @Anonymitaet @maxsxu @tisonkun ,I have been finished coding and tested it successful in my public repository. see the [action](https://github.com/mangoGoForward/C/actions/runs/3095157605) and [workflow](https://github.com/mangoGoForward/C/blob/master/.github/workflows/semantic.yaml), if it possible to move this action to [pulsar-test-infra](https://github.com/apache/pulsar-test-infra)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] maxsxu commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
maxsxu commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966784550
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
I think it's good to consolidate docs-related jobs into one workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966692052
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
We can filter out label events with an if condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1241693293
If this job fails, a reminder/error msg should be shown as below, similar to https://github.com/apache/pulsar-test-infra/blob/a30bb7884b796e9abb294adc8548406471bc3175/docbot/main.go#L18
```
Please follow [Pulsar Pull Request Naming Convention Guide](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#) to write a PR title.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1244812842
> Seems the `action-semantic-pull-request` cannot meet this requirement currently. @mangoGoForward might need to do more custom work here.
Yes, I will improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r983306840
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
Good catch! We should add a new workflow, which only listens to the `synchronize` event on PR, and then you also add `subjectPatternError` value on `amannn/action-semantic-pull-request@v4`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1254443004
> @mangoGoForward Thank you! I think it's pretty close. May need to make the `TitleUnmatchPattern` as an issue comment to achieve the effect mentioned by @Anonymitaet before.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] maxsxu commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
maxsxu commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1250788937
> > Hi @mangoGoForward any blockers?
>
> Yes, seems we should write an new APP in [pulsar-test-infra](https://github.com/apache/pulsar-test-infra) to customize the error message instead of using [semantic GitHub Action](https://github.com/amannn/action-semantic-pull-request)， like:
>
> ```
> Please follow [Pulsar Pull Request Naming Convention Guide](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#) to write a PR title.
> ```
>
> I will test it well and continue to commit
Thanks @mangoGoForward Please feel free to reach out to me if you need any help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1272728300
Closed by https://github.com/apache/pulsar/pull/17961, thank you all for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mangoGoForward commented on pull request #17557: [feat][ci]: Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1241462292
Please have a review when you have free time
@maxsxu @Anonymitaet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17557: [feat][ci]: Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#discussion_r966607454
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -43,4 +43,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LABEL_WATCH_LIST: 'doc,doc-required,doc-not-needed,doc-complete'
- LABEL_MISSING: 'doc-label-missing'
\ No newline at end of file
+ LABEL_MISSING: 'doc-label-missing'
+
+ semantic:
+ name: Check PR title
+ runs-on: ubuntu-latest
+ steps:
+ - uses: amannn/action-semantic-pull-request@v4
+ continue-on-error: true
+ env:
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ with:
+ types: |
+ feat
+ improve
+ fix
+ cleanup
+ refactor
+ revert
+
+ scopes: |
+ admin
+ broker
+ cli
+ io
+ fn
+ meta
+ monitor
+ proxy
+ schema
+ sec
+ sql
+ storage
+ offload
+ txn
+ java
+ cpp
+ py
+ ws
+ test
+ ci
+ build
+ misc
+ doc
+ blog
+ site
+
+ headerPattern: '^(?:\[(\w+)\])?(?:\[(\w+)\])? (.+)$'
Review Comment:
This job should be in a new workflow. We don't run it for every labeled/unlabeled event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] maxsxu commented on pull request #17557: [feat][ci] Check PR title with semantic
Posted by GitBox <gi...@apache.org>.
maxsxu commented on PR #17557:
URL: https://github.com/apache/pulsar/pull/17557#issuecomment-1241708635
> If this job fails, a reminder/error msg should be shown as below, similar to https://github.com/apache/pulsar-test-infra/blob/a30bb7884b796e9abb294adc8548406471bc3175/docbot/main.go#L18
>
> ```
> Please follow [Pulsar Pull Request Naming Convention Guide](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#) to write a PR title.
> ```
Seems the `action-semantic-pull-request` cannot meet this requirement currently. @mangoGoForward might need to do more custom work here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org