[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #38: [FLINK-26181] Support manual savepoint triggering in the operator

[GitBox <gi...@apache.org>]

Aitozi commented on a change in pull request #38:
URL: https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819728122



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -109,6 +110,14 @@ public JobReconciler(
             }
         }
 
+        if (SavepointUtils.checkSavepointAnnotation(flinkApp)) {
+            triggerSavePoint(flinkApp, effectiveConfig);
+            SavepointUtils.removeSavepointAnnotation(flinkApp);

Review comment:
       I think the concern make sense, since the operator's semantic is try to reconcile to the desired state, and the desired state changed by the operator itself is not common way.
   Can we attach the annotation of  `flinkdeployments.flink.apache.org/trigger-savepoint-timestamp=1646411987`
   and stored the last triggered timestamp in status. If the status timestamp < the spec timestamp , It will need to trigger again and update the status.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org