You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/01/15 13:45:26 UTC
[GitHub] [incubator-doris] WingsGo opened a new pull request #2777: [Alter]
Add more schema change to varchar type
WingsGo opened a new pull request #2777: [Alter] Add more schema change to varchar type
URL: https://github.com/apache/incubator-doris/pull/2777
#2776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli merged pull request #2777: [Alter] Add
more schema change to varchar type
Posted by GitBox <gi...@apache.org>.
chaoyli merged pull request #2777: [Alter] Add more schema change to varchar type
URL: https://github.com/apache/incubator-doris/pull/2777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on issue #2777: [Alter] Add
more schema change to varchar type
Posted by GitBox <gi...@apache.org>.
WingsGo commented on issue #2777: [Alter] Add more schema change to varchar type
URL: https://github.com/apache/incubator-doris/pull/2777#issuecomment-585751181
@imay @morningman @chaoyli Plz review this PR~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request
#2777: [Alter] Add more schema change to varchar type
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #2777: [Alter] Add more schema change to varchar type
URL: https://github.com/apache/incubator-doris/pull/2777#discussion_r367768634
##########
File path: be/test/olap/schema_change_test.cpp
##########
@@ -212,6 +212,47 @@ class TestColumn : public testing::Test {
ASSERT_EQ(_column_writer->create_row_index_entry(), OLAP_SUCCESS);
}
+ void test_convert_to_varchar(std::string type_name, int type_size, const std::string& value, OLAPStatus expected_st) {
Review comment:
std::string& type_name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #2777: [Alter] Add
more schema change to varchar type
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #2777: [Alter] Add more schema change to varchar type
URL: https://github.com/apache/incubator-doris/pull/2777#issuecomment-575879258
Plz update the help doc of alter table. Add new conversions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2777:
[Alter] Add more schema change to varchar type
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2777: [Alter] Add more schema change to varchar type
URL: https://github.com/apache/incubator-doris/pull/2777#discussion_r367736246
##########
File path: be/src/olap/types.h
##########
@@ -477,6 +477,11 @@ struct FieldTypeTraits<OLAP_FIELD_TYPE_FLOAT> : public BaseFieldtypeTraits<OLAP_
*reinterpret_cast<CppType*>(buf) = value;
return OLAP_SUCCESS;
}
+ static std::string to_string(const void* src) {
+ char buf[1024] = {'\0'};
+ snprintf(buf, sizeof(buf), "%.10f", *reinterpret_cast<const CppType*>(src));
Review comment:
Better use FloatToBuffer and DoubleToBuffer in be/src/gutil/strings/numbers.h to unify our float->string output format
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org