[jira] [Commented] (OAK-2252) VersionGCSupport for RDB persistence

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291845#comment-14291845 ] 

Julian Reschke commented on OAK-2252:
-------------------------------------

Discussed with [~mreutegg]:

- make _deletedOnce an indexed property in RDBDocumentStore

- modify VersionGCSupport to attempt to fetch only documents where the flag is set (requires some hackery because the type of _deletedOnce is boolean, not integer

- test this

If this works, consider to change the type to integer if there's a good migration story for MongoDB persistences 

> VersionGCSupport for RDB persistence
> ------------------------------------
>
>                 Key: OAK-2252
>                 URL: https://issues.apache.org/jira/browse/OAK-2252
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: rdbmk
>    Affects Versions: 1.1.1
>            Reporter: Julian Reschke
>            Priority: Minor
>             Fix For: 1.2
>
>
> The DocumentMK's VersionGCSupport code currently special-cases the Mongo persistence. 
> Needed are two optimized queries:
> 1) deletedOnce = true AND modifiedInSecs < lastModified
> 2) sdType in (....) AND sdMaxRevTimeInSecs < oldestRevTimeStamp
> (where in the case of 2) the matching documents can be removed right away)
> TODO:
> a) find out which of these system properties ought to be indexed properties
> b) decide on whether we can implement this as generic interface extension of DocumentStore, or whether we add custom code for the RDBDocumentStore similary to what Mongo does
> on b): I think we should aim for *removing* persistence-specific code from the kernel, so we probably should add extension interfaces for these.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)