Re: svn commit: r904901 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

[Julian Foad <ju...@btopenworld.com>]

On Sun, 2010-01-31 at 00:20 +0200, Daniel Shahaf wrote:
> danielsh@apache.org wrote on Sat, 30 Jan 2010 at 22:08 -0000:
> > Author: danielsh
> > Date: Sat Jan 30 22:08:45 2010
> > New Revision: 904901
> > 
> > URL: http://svn.apache.org/viewvc?rev=904901&view=rev
> > Log:
> > * subversion/libsvn_fs_fs/fs_fs.c
> >   (commit_obliteration_body):
> >     When obliterating a packed revision, error out gracefully instead of
> >     asserting.  This makes the C tests report "XFAIL" rather than "Aborted".
> > 
> 
> Specifically, this was found by fs-test:36:obliterate_1().  But the
> function I patched --- commit_obliteration_body() --- looks like it
> actually does something... I thought obliterate wasn't implemented for
> FSFS yet?  And if that's the case, what *does* that function currently
> do?

I started to implement it before I worked on BDB. What you see there is
that early, incomplete attempt, and I probably need to throw it away and
start again.

> [1] I imagine the special build flags only enable the UI and public API
> bits of 'obliterate', though.

Correct. Only the UI, actually.

- Julian