You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Christopher Tubbs (JIRA)" <ji...@apache.org> on 2013/10/28 20:30:33 UTC

[jira] [Commented] (ACCUMULO-1820) Suppress compiler warnings from hadoop1/2 switchover

    [ https://issues.apache.org/jira/browse/ACCUMULO-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807141#comment-13807141 ] 

Christopher Tubbs commented on ACCUMULO-1820:
---------------------------------------------

Most of these are in our test code with `new Job()`.

Alternatively, instead of suppressing warnings, we could use reflection in a helper method to check to see if `Job.getInstance()` exists, and use that instead of `new Job()`. Or we could use a helper method and just suppress it just once.

However, some of these are in examples, too, and we shouldn't suppress warnings in example code... we should have better examples. I haven't looked at the other deprecated code in Hadoop 2, but I think there's some stuff in the FileSystem in addition to the MapReduce stuff.

One thing we shouldn't do is suppress warnings across an entire class or a large method... because that hides code that we'd probably want to change.

> Suppress compiler warnings from hadoop1/2 switchover
> ----------------------------------------------------
>
>                 Key: ACCUMULO-1820
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1820
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.6.0
>
>
> Switching over from Hadoop1 as the default to Hadoop2 introduced compilation warnings as Hadoop2 introduces new APIs.
> Given that we want to still maintain backwards compatibility, we have to just suppress the warnings, as moving to the new API would break our compatibility.



--
This message was sent by Atlassian JIRA
(v6.1#6144)