[GitHub] spark pull request #14269: [SPARK-15703] [Scheduler][Core][WebUI] Make Liste...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14269#discussion_r118106331
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
    @@ -32,18 +33,24 @@ import org.apache.spark.util.Utils
      * has started will events be actually propagated to all attached listeners. This listener bus
      * is stopped when `stop()` is called, and it will drop further events after stopping.
      */
    -private[spark] class LiveListenerBus extends SparkListenerBus {
    +private[spark] class LiveListenerBus(val sparkContext: SparkContext) extends SparkListenerBus {
    --- End diff --
    
    I'm modifying LiveListenerBus now and noticed that we're passing in `sparkContext` even though we only use it to access `conf`. I think it would have been better to just pass in `conf` here. It would make the initialization order constraints a lot clearer, too: right now it's not immediately clear why `eventQueue` needs to be a `lazy val`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org