You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/21 18:01:42 UTC
[GitHub] [incubator-nuttx] robertalexa2000 opened a new pull request, #7647: Esp32 sparrow kit
robertalexa2000 opened a new pull request, #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647
These patches add support for a new custom-made board, esp32-sparrow, which is built upon esp32-wrover-kit. The purpose to esp32-sparrow-kit is to enable by default support for various peripherals. So far, only LTR308 and SD card are supported. The others will be address in separate future patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1323326800
Try run your configuration and then run `make savedefconfig` and compare saved config with one in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#discussion_r1029678052
##########
boards/xtensa/esp32/common/src/esp32_ltr308.c:
##########
@@ -0,0 +1,87 @@
+/****************************************************************************
+ * boards/xtensa/esp32/common/src/esp32_ltr308.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdio.h>
+#include <debug.h>
+
+#include <nuttx/arch.h>
+#include <nuttx/sensors/ltr308.h>
+#include <nuttx/i2c/i2c_master.h>
+
+#include "esp32_board_i2c.h"
+#include "esp32_i2c.h"
+#include "esp32_ltr308.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: board_ltr308_initialize
+ *
+ * Description:
+ * Initialize and register the LTR308 Lite-On ambient light sensor driver.
+ *
+ * Input Parameters:
+ * devno - The device number, used to build the device path as
+ * /dev/uorb/sensor_lightN
+ * busno - The I2C bus number
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+int board_ltr308_initialize(int devno, int busno)
+{
+ struct i2c_master_s *i2c;
+ int ret;
+
+ sninfo("Initializing LTR308!\n");
+
+ /* Initialize LTR308 */
+
+ i2c = esp32_i2cbus_initialize(busno);
+
+ if (i2c)
Review Comment:
```suggestion
i2c = esp32_i2cbus_initialize(busno);
if (i2c !- NULL)
```
optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1323642283
> No board-level README.txt file to describe the board?
One useful thing to document: since this board support is being made public, how can someone obtain one of these boards? (Is it manufactured by a company? Is there a public reference design? Etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] robertalexa2000 commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
robertalexa2000 commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1323305308
> > @xiaoxiang781216 do you have any idea why the build failed? I can't see any errors in the log, am I missing something?
>
> You based your config on some older version. Please normalize defconfig in this PR to reflect the actual Kconfig tree dependencies
Could you please be a little more explicit? What do you mean by the actaul Kconfig dependencies? The defconfig is based on the esp32-wrover-kit nsh and mmcsd defconfigs so I thought it would be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1323946400
> Maybe instead of a README, I could add these details in boards/Kconfig?
Sure, that would be good enough. The explanation you wrote above is perfectly fine. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1323263545
> @xiaoxiang781216 do you have any idea why the build failed? I can't see any errors in the log, am I missing something?
You based your config on some older version. Please normalize defconfig in this PR to reflect the actual Kconfig tree dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] robertalexa2000 commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
robertalexa2000 commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1323392030
@pkarashchenko Thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] robertalexa2000 commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
robertalexa2000 commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1322617468
@xiaoxiang781216 do you have any idea why the build failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#discussion_r1028985298
##########
boards/Kconfig:
##########
@@ -253,6 +253,22 @@ config ARCH_BOARD_ESP32_LYRAT
Development Framework (ADF). It is designed for smart speakers and smart-home
applications. This port is for board version 4.3.
+config ARCH_BOARD_ESP32_SPARROWKIT
+ bool "Espressif ESP-SPARROW-KIT"
+ depends on ARCH_CHIP_ESP32WROVER
+ select ARCH_HAVE_LEDS
+ select ARCH_HAVE_BUTTONS
+ select ARCH_HAVE_IRQBUTTONS if ESP32_GPIO_IRQ
+ ---help---
+ ESP32-SPARROW-KIT is a custom made development board based on Espressif's
+ ESP32WROVER chip. It features the following integrated components:
+ ESP32-WROVER-B module
+ LTR308 ambient light sensor
+ BME180 sensor
+ MicroSD card slot
+ LCD screen
+ I2S microphone
Review Comment:
TABs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] robertalexa2000 commented on pull request #7647: Esp32 sparrow kit
Posted by GitBox <gi...@apache.org>.
robertalexa2000 commented on PR #7647:
URL: https://github.com/apache/incubator-nuttx/pull/7647#issuecomment-1323850178
> > No board-level README.txt file to describe the board?
>
> One useful thing to document: since this board support is being made public, how can someone obtain one of these boards? (Is it manufactured by a company? Is there a public reference design? Etc.)
I could add a README but I don't know what any extra info it can provide, besides what I summarized in boards/Kconfig.
Sparrow-kit is basically an ESP32-Wrover with a few extra peripherals soldered into it. It's not manufactured by a company, it was custom-made for a university course. Its purpose is to allow the user to enable all these add-ons by default, without the need of manually checking the necessary configs.
Maybe instead of a README, I could add these details in boards/Kconfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org