You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/07/20 20:59:51 UTC

[GitHub] [druid] maytasm commented on pull request #10171: Add integration tests for query retry on missing segments

maytasm commented on pull request #10171:
URL: https://github.com/apache/druid/pull/10171#issuecomment-661330263


   > > The code coverage bot doesn't like missing tests for the classes I added for testing. Those classes were added in `integration-tests` module, and I think we can ignore this report.
   > 
   > I think we can ignore all classes within the `integration-tests` module from the code coverage check. It looks like we can add that exclusion around here -
   > 
   > https://github.com/apache/druid/blob/2b48de074a855d3c36ff588e90846644fc4b5f42/.travis.yml#L168
   > 
   > If we need another patch, can you add the exclusion, if the patch is good to go, I'm ok with adding the exclusion in another PR.
   
   Which job did it failed on? I thought the integration-test does not have any job with the code coverage running


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org